Descriptor should be materialized#416
Descriptor should be materialized#416zhouhao3 wants to merge 1 commit intoopencontainers:masterfrom zhouhao3:test-mlist
Conversation
zhouhao3
changed the title
| "digest": { | ||
| "$ref": "#definitions/digest" | ||
| "config": { | ||
| "$ref": "#content-descriptor.json" |
There was a problem hiding this comment.
I'm fine shifting the descriptor properties out into their own property, but manifest-lists currently don't do that. I think you might be confusing manifestDescriptor (used in the manifest-list) with the manifest schema.
There was a problem hiding this comment.
Perhaps I naMaybe I'm a little problem on the naming or understand， but I think in the manifest_list.go, Descriptor is the need for specific, or else when the call will be given the wrong, like“Descriptor has no field or method validate”
There was a problem hiding this comment.
It sounds like you're talking about this Travis error from opencontainers/image-tools#51. But that's a Go compilation error; I don't see how it relates to the JSON Schema change you're proposing here.
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
I don't understand the reason for this change. |
3 participants
When I modify the program in the image-tools, I found that if the Descriptors do not concrete, you can not call it, so I think it should be specific
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com