manifest test case should involve required fields#446
Merged
jonboulle merged 1 commit intoopencontainers:masterfrom Nov 17, 2016
xiekeyang:manifest-unit-test
Merged
manifest test case should involve required fields#446jonboulle merged 1 commit intoopencontainers:masterfrom xiekeyang:manifest-unit-test
jonboulle merged 1 commit intoopencontainers:masterfrom
xiekeyang:manifest-unit-test
Conversation
Signed-off-by: xiekeyang <xiekeyang@huawei.com>
Contributor
|
On Sat, Nov 05, 2016 at 04:40:37AM -0700, xiekeyang wrote:
fb409fd looks good to me. Now it fails with: mediaType: Does not match pattern '^[a-z]+/[0-9a-zA-Z.+]+$' So a similar test with mediaType set to text/png would pass, although |
Contributor
Author
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test case want to return failure only when
invalidmedia type.However, it lack the required fields, and will return failure whatever
mediaTypeis.So, it should be completed the accurate required fields, to make sure it to be our expectation.
Signed-off-by: xiekeyang xiekeyang@huawei.com