image-layout.md: clarify the layout file name MUST be oci-layout#461
Closed
coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
Closed
image-layout.md: clarify the layout file name MUST be oci-layout#461coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
oci-layout#461coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
Conversation
wking
reviewed
Nov 17, 2016
image-layout.md
Outdated
| The image layout MUST also contain a file that is used to identify the layout version: | ||
| The image layout MUST also contain a file that is used to identify the layout version, the file name MUST be `oci-layout`: | ||
|
|
||
| - `oci-layout` MUST contain a JSON object with a version field `{"imageLayoutVersion": "1.0.0"}` and MAY include additional fields. |
Contributor
There was a problem hiding this comment.
How about rephrasing both of these lines to something like:
The image layout MUST also contain an
oci-layoutfile that is used to identify the layout version.
oci-layoutMUST contain a JSON object withimageLayoutVersionset to1.0.0.
oci-layoutMAY include additional fields.
Member
Author
There was a problem hiding this comment.
I'm ok with this rephrasing.
coolljt0725
force-pushed
the
oci-layout
branch
from
c5b8881 to
bd05a3f
Compare
Member
Author
|
updated per @wking 's suggestion |
Signed-off-by: Lei Jitang <leijitang@huawei.com>
Member
Author
|
This is a dup of #434 closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang leijitang@huawei.com