schema: add checkPlatform#469
Closed
zhouhao3 wants to merge 1 commit intoopencontainers:masterfrom
zhouhao3:config-test
Closed
schema: add checkPlatform#469zhouhao3 wants to merge 1 commit intoopencontainers:masterfrom zhouhao3:config-test
zhouhao3 wants to merge 1 commit intoopencontainers:masterfrom
zhouhao3:config-test
Conversation
Contributor
Contributor
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
Author
Contributor
|
These are SHOULDs, not MUSTs. Why should we validate them? |
Member
|
i'm okay with them being checked, but not to FAIL a validation. |
Contributor
|
On Wed, Nov 30, 2016 at 01:42:16PM -0800, Vincent Batts wrote:
i'm okay with them being _checked_, but not to FAIL a validation.
+1. We should probably table this until we settle on strict handling
(see the discussion in opencontainers/image-spec#452 and me trying to
outline the issue in opencontainers/image-tools#66).
|
Author
Because these two are required attributes, and as the specification says: The name of the operating system which the image is built to run on. If it is the verification of the system, only by JSON to restrict the type is not rigorous, it should be the value of its specific judgment. |
Author
|
Due to my mistakes, resulting in this PR can not be updated, I will close this, and then open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes opencontainers/image-tools#39
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com