Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Validate oci-layout version#50

Closed
coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
coolljt0725:layout
Closed

Validate oci-layout version#50
coolljt0725 wants to merge 1 commit intoopencontainers:masterfrom
coolljt0725:layout

Conversation

@coolljt0725
Copy link
Copy Markdown
Member

OCI image specification has required that
"oci-layout" MUST contain a JSON object with a version field {"imageLayoutVersion": "1.0.0"},
the image tool should follow this rule.

Signed-off-by: Lei Jitang leijitang@huawei.com

Copy link
Copy Markdown
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also covered by #5, but I'm ok with landing this here if folks don't want to wait for the maintainers to review #5.

image/image.go Outdated
}

func validate(w walker, refs []string, out *log.Logger) error {
if err := validatImageLayout(w); err != nil {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validatImageLayoutvalidateImageLayout.

@coolljt0725 coolljt0725 force-pushed the layout branch 2 times, most recently from 8c1e6e0 to 25edff2 Compare October 25, 2016 06:08
OCI image specification has required that
`"oci-layout" MUST contain a JSON object with a version field {"imageLayoutVersion": "1.0.0"}`,
the image tool should follow this rule.

Signed-off-by: Lei Jitang <leijitang@huawei.com>
@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 8, 2017

I'm +1, but make lint failure needs to be fixed.

@coolljt0725
Copy link
Copy Markdown
Member Author

wait for opencontainers/image-spec#519 and then rebase

@coolljt0725
Copy link
Copy Markdown
Member Author

close by #84

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants