(Re)add ARM support on Windows and Linux #369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarny
force-pushed
the
issue368
branch
4 times, most recently
from
c2f7947 to
cb3084e
Compare
agarny
force-pushed
the
issue368
branch
16 times, most recently
from
a338128 to
de2e566
Compare
…our third-party libraries. Indeed, this is because we build llvm-tblgen and clang-tblgen using a bash script, so to get env.DLLVMCLANG_LLVM_TABLEGEN and env.DLLVMCLANG_CLANG_TABLEGEN properly set, we need to stick to bash. If we were not to do that on Windows, then env.DLLVMCLANG_LLVM_TABLEGEN and env.DLLVMCLANG_CLANG_TABLEGEN would be split in two!? Indeed, CMake would eventually warn about ignoring "D:/a/libopencor/libopencor/build/.1.8/build/bin/llvm-tblgen.exe" and ".1.8/build/bin/clang-tblgen.exe"!?
agarny
force-pushed
the
issue368
branch
6 times, most recently
from
ce18290 to
2d42c85
Compare
agarny
force-pushed
the
issue368
branch
2 times, most recently
from
b19bea3 to
f140469
Compare
Indeed, to build LLVM+Clang on Windows ARM is not possible using MSVC.
Contributor
Author
|
Closing in favour of PR #372. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368.