Skip to content

Cleaning up #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agarny merged 5 commits into from
Dec 4, 2025
Merged

Cleaning up #526

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b0b9f1
New version.
agarny Dec 3, 2025
ecaf4f9
SedChangeAttribute: fixed a warning that we generate.
agarny Dec 3, 2025
010c828
Sphinx: don't allow the use of Sphinx 9.0.0+.
agarny Dec 3, 2025
4bcc8c5
modp_b64: upgraded to commit 5068510.
agarny Dec 3, 2025
623fbec
libCellML: upgraded to commit 7cc5bea.
agarny Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.20251030.0
0.20251204.0
4 changes: 2 additions & 2 deletions src/sed/sedchangeattribute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void SedChangeAttribute::Impl::apply(const SedInstanceTaskPtr &pInstanceTask,
auto voiVariable {pAnalyserModel->voi()->variable()};
auto voiComponent {owningComponent(voiVariable)};

addWarning(std::string("The variable of integration '").append(voiVariable->name()).append("' in component '").append(voiComponent->name()).append("'cannot be changed. Only state variables and constants can be changed."));
addWarning(std::string("The variable of integration '").append(voiVariable->name()).append("' in component '").append(voiComponent->name()).append("' cannot be changed. Only state variables and constants can be changed."));

return;
}
Expand Down Expand Up @@ -155,7 +155,7 @@ void SedChangeAttribute::Impl::apply(const SedInstanceTaskPtr &pInstanceTask,
}

if (!isParameterSet) {
addWarning(std::string("The variable '").append(mComponentName).append("' in component '").append(mVariableName).append("'could not be found and therefore could not be changed."));
addWarning(std::string("The variable '").append(mVariableName).append("' in component '").append(mComponentName).append("' could not be found and therefore could not be changed."));
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/api/solver/coveragetests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ limitations under the License.
TEST(CoverageSolverTest, odeChanges)
{
static const libOpenCOR::ExpectedIssues EXPECTED_ISSUES {{
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the variable of integration 'time' in component 'environment'cannot be changed. Only state variables and constants can be changed."},
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the variable 'membrane' in component 'X'could not be found and therefore could not be changed."},
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the variable of integration 'time' in component 'environment' cannot be changed. Only state variables and constants can be changed."},
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the variable 'X' in component 'membrane' could not be found and therefore could not be changed."},
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the computed constant 'E_Na' in component 'sodium_channel' cannot be changed. Only state variables and constants can be changed."},
{libOpenCOR::Issue::Type::WARNING, "Task instance | Change attribute: the algebraic variable 'i_Stim' in component 'membrane' cannot be changed. Only state variables and constants can be changed."},
}};
Expand Down
4 changes: 2 additions & 2 deletions tests/bindings/javascript/solver.coverage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ test.describe('Solver coverage tests', () => {
assertIssues(loc, instance, [
[
loc.Issue.Type.WARNING,
"Task instance | Change attribute: the variable of integration 'time' in component 'environment'cannot be changed. Only state variables and constants can be changed."
"Task instance | Change attribute: the variable of integration 'time' in component 'environment' cannot be changed. Only state variables and constants can be changed."
],
[
loc.Issue.Type.WARNING,
"Task instance | Change attribute: the variable 'membrane' in component 'X'could not be found and therefore could not be changed."
"Task instance | Change attribute: the variable 'X' in component 'membrane' could not be found and therefore could not be changed."
],
[
loc.Issue.Type.WARNING,
Expand Down
4 changes: 2 additions & 2 deletions tests/bindings/python/test_solver_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ def test_ode_changes():
expected_issues = [
[
loc.Issue.Type.Warning,
"Task instance | Change attribute: the variable of integration 'time' in component 'environment'cannot be changed. Only state variables and constants can be changed.",
"Task instance | Change attribute: the variable of integration 'time' in component 'environment' cannot be changed. Only state variables and constants can be changed.",
],
[
loc.Issue.Type.Warning,
"Task instance | Change attribute: the variable 'membrane' in component 'X'could not be found and therefore could not be changed.",
"Task instance | Change attribute: the variable 'X' in component 'membrane' could not be found and therefore could not be changed.",
],
[
loc.Issue.Type.Warning,
Expand Down
Loading