Fix VGG::getDefaultName unresolved external symbol link error #4049
+5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
When compiling DSO
xfeatures2dwith optionOPENCV_SKIP_FEATURES2D_DOWNLOADING=ONon Windows, a problem was discovered:However, this problem does not exist in the boostdesc implementation, which is built on a similar principle.
This patch fixes this behavior by moving the implementation of function
VGG::getDefaultName()out of the macroOPENCV_XFEATURES2D_HAS_VGG_DATAscope.This bug affects all versions starting with
4.7.0and up to the current4.xand5.x.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request