Skip to content

Update SMTP configuration guide with examples#62

Open
thkn-hofa wants to merge 2 commits intoopencve:masterfrom
thkn-hofa:smtp-config
Open

Update SMTP configuration guide with examples#62
thkn-hofa wants to merge 2 commits intoopencve:masterfrom
thkn-hofa:smtp-config

Conversation

@thkn-hofa
Copy link

Added configuration examples for unauthenticated SMTP in the documentation.

Configuration is different between web/opencve/conf/settings.py and scheduler/airflow.cfg: the first allows to omit username and password variables while the second needs them empty or it throws errors.

Added configuration examples for unauthenticated SMTP in the documentation.

Configuration is different between 'web/opencve/conf/settings.py' and 'scheduler/airflow.cfg': the first allows to omit username and password variables while the second needs them empty or it throws errors.
Copy link
Member

@ncrocfer ncrocfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the clarification about unauthenticated SMTP is useful 👍

However, duplicating the full configuration just to show the unauthenticated case makes the documentation heavier and harder to maintain.

I think it would be cleaner to keep the existing examples and simply add a comment next to username / password, e.g. leave it empty for unauthenticated SMTP (or must be present but empty for Airflow).

That way we document the behavior without duplicating the whole config block.

Updated SMTP configuration details for unauthenticated SMTP, including comments for clarity. Removed example configurations for unauthenticated SMTP.
@thkn-hofa
Copy link
Author

Thanks for the PR, the clarification about unauthenticated SMTP is useful 👍

However, duplicating the full configuration just to show the unauthenticated case makes the documentation heavier and harder to maintain.

I think it would be cleaner to keep the existing examples and simply add a comment next to username / password, e.g. leave it empty for unauthenticated SMTP (or must be present but empty for Airflow).

That way we document the behavior without duplicating the whole config block.

You're right, great input

@thkn-hofa thkn-hofa requested a review from ncrocfer March 3, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants