feat: Add support for shortNames and singularName#33
Merged
Conversation
Add ShortNamesProvider and SingularNameProvider interfaces to enable resources to define short names and singular names by implementing getter methods on the resource type, following the existing pattern used for NamespaceScoped().
dermorz
force-pushed
the
feature/32-add-support-for-resource-singular-and-short-names
branch
from
421e474 to
57a0688
Compare
Just to please my inner monk.
When ShortNames are present, NewStore returns a wrapped store. rest.Unwrap() returns the inner *genericregistry.Store but modifying it in-place corrupts the main store. So we make a value copy to keep the status subresource's UpdateStrategy isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ShortNamesProvider and SingularNameProvider interfaces to enable resources to define short names and singular names by implementing getter methods on the resource type, following the existing pattern used for NamespaceScoped().
/closes #32