Conversation
trevex
reviewed
Feb 18, 2026
| @@ -0,0 +1,19 @@ | |||
| ## Issue | |||
|
|
|||
| - [ ] [Solutions Arsenal xx](https://github.com/opendefensecloud/solution-arsenal/issues/xx) | |||
Contributor
There was a problem hiding this comment.
Solutions Arsenal -> Solution Arsenal?
Maybe just the link is fine as well, as github renders it properly anyway, e.g. #155
Contributor
yocaba
reviewed
Mar 9, 2026
Contributor
|
May I suggest a different approach? I would keep the checkboxes minimal and only keep those that are always applicable, so from the PR list-view we can see a 2/2. Other than that I would give the contributer prompts to leave relevant information for the reviewer. Things like linter, coverage, fmt, codegen should be checked automatically and should not have their explicit checkboxes. For example: ## What
<!-- One sentence summary -->
Closes #
## Why
<!-- Motivation / problem being solved. Skip if obvious from the linked issue. -->
## Testing
<!-- How was this tested? e.g. unit, envtest, manual against vX.Y.Z -->
## Notes for reviewers
<!-- CRD/API changes, RBAC changes, new watches, breaking changes, upgrade path.
Delete if not applicable. -->
## Checklist
- [ ] Tests added/updated
- [ ] No breaking changes (or upgrade path documented above) |
Contributor
|
We should also add "readable commit history (squashed, rebased as required)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR adds a pull request template to
.github/PULL_REQUEST_TEMPLATE/pull_request_template.md. This PR follows the suggested template.Checklist
Additional Authors
none