Fix instruction text placeholder replacement#142
Open
LuXcDD wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
CarlaVoiceDatasetwhere instruction placeholders were not actually replaced ininstruction_text.The previous code called
str.replace(...)without assigning the returned string back toinstruction_text. Since Python strings are immutable, placeholders such as[x],left/right, and[y]remained unchanged.Changes
instruction_text.replace(...)back toinstruction_textWhy this matters
This ensures generated instruction text correctly reflects values from
info['instruction_args']instead of leaving template placeholders in the final string.Testing
instruction_textas intended