Update core, gradle and SDK

[TomTasche]

No description provided.

[claude]

Claude finished @TomTasche's task —— View job

---

Review Tasks

• Analyze dependency version updates
• Review gradle configuration changes
• Examine new Android API 35 themes file
• Check for compatibility and breaking changes
• Provide comprehensive review feedback

---

Pull Request Review: Update core, gradle and SDK

I've reviewed the changes in this PR that updates various dependencies and SDK versions. Here's my comprehensive feedback:

Summary of Changes

1. ODR Core Library: Updated from 5.0.7 → 5.1.1
2. Android Gradle Plugin: Updated from 8.5.2 → 8.13.1
3. Gradle Wrapper: Updated from 8.9 → 8.13
4. Android SDK: Updated compileSdk and targetSdk from 34 → 35
5. New Theme File: Added Android API 35 specific theme configuration

Code Quality and Best Practices ✅

• Good: Version updates are incremental and follow semantic versioning
• Good: New API 35 theme file follows the existing pattern of API-specific resource directories (v29, v35)
• Good: Theme attributes are consistent with existing theme structure

Potential Issues and Concerns ⚠️

1. Edge-to-Edge Enforcement (app/src/main/res/values-v35/themes.xml:11)

   • The new android:windowOptOutEdgeToEdgeEnforcement attribute is set to true
   • This opts out of Android 35's edge-to-edge enforcement, which may affect UI layout on newer devices
   • Recommendation: Ensure this is intentional and test thoroughly on Android 35 devices to verify UI elements aren't cut off

2. Gradle Version Jump

   • Jumping from Gradle 8.9 → 8.13 is significant (4 minor versions)
   • Recommendation: Review the Gradle 8.x release notes for any breaking changes or deprecations

3. Android Gradle Plugin Update

   • AGP 8.13.1 is a major jump from 8.5.2
   • Recommendation: Verify build times and check for any new lint rules or warnings

Performance Considerations 🚀

• Gradle 8.13 includes performance improvements that should reduce build times
• ODR Core 5.1.1 may include performance enhancements (would need to check release notes)
• No performance regressions expected from these updates

Security Concerns 🔒

• All updates appear to be moving to newer, more secure versions
• No security vulnerabilities identified in the changes
• Good: Following best practice of keeping dependencies up to date

Test Coverage 🧪

• Missing: No test changes or additions to verify compatibility with Android 35
• Recommendation: Add UI tests specifically for Android 35 edge-to-edge behavior
• Recommendation: Run full test suite on Android 35 emulator/device to ensure compatibility

Additional Recommendations

1. Documentation: Consider adding a comment in the v35 themes file explaining why windowOptOutEdgeToEdgeEnforcement is needed

2. Changelog: Update the project's changelog or release notes to document these dependency updates

3. Build Verification: Ensure CI/CD pipeline runs successfully with these updates

4. Runtime Testing: Test on physical devices running Android 35 (API level 35) to verify:

   • UI renders correctly with edge-to-edge opt-out
   • Dark mode behavior remains consistent
   • No crashes or unexpected behavior

Overall Assessment

The changes look good and follow best practices for dependency management. The main concern is ensuring the edge-to-edge opt-out is intentional and properly tested. Once UI behavior is verified on Android 35 devices, this PR should be ready to merge.