Skip to content

test: avoid chmod for unreadable log tests#127

Merged
Emin017 merged 1 commit into
mainfrom
emin/avoid-chmod-for-log-tests
Jun 24, 2026
Merged

test: avoid chmod for unreadable log tests#127
Emin017 merged 1 commit into
mainfrom
emin/avoid-chmod-for-log-tests

Conversation

@Emin017

@Emin017 Emin017 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

Scope

Select the areas touched by this PR:

  • CLI - command behavior, Typer command surface, output formats, or workspace commands.
  • Flow/runtime - workspace lifecycle, EngineFlow, step execution, logs, metrics, or artifacts.
  • EDA integration - Yosys, ECC-Tools, DreamPlace, KLayout, PDKs, or native/runtime wrappers.
  • Build/package - Bazel, Nix, PyInstaller, wheels, uv.lock, or release artifacts.
  • CI/release - GitHub Actions, version checks, changelog, or release automation.
  • Tests/docs only

What Changed

Validation

List the commands you ran. Mark checks that are not applicable as N/A.

  • uv run pytest test/
  • Focused pytest:
  • uv run ruff check chipcompiler test
  • uv run ruff format --check chipcompiler test
  • bazel build //:build_ecc_cli_bundle
  • PyInstaller smoke: ecc --help, ecc --version, ecc version --json
  • Nix smoke: nix run .#cli -- --help
  • Manual flow smoke:
  • Other:

Skipped checks and reason:

Runtime And Packaging Impact

  • No runtime or packaging impact
  • CLI output or machine-readable contract changed
  • Workspace layout, flow state, or artifact paths changed
  • Native toolchain or wrapper behavior changed
  • ecc-tools or ecc-dreamplace dependency changed
  • PyInstaller, Nix, Bazel, or release artifact changed

Notes:

Checklist

  • I kept the change scoped to ECC.
  • I updated docs or user-facing CLI text where behavior changed.
  • I included lockfile or version metadata updates when dependencies changed.
  • I documented any submodule updates and why they are needed.
  • I did not include local caches, virtual environments, or generated build outputs.
  • I explained skipped validation and remaining risk.

@Emin017 Emin017 added this to the 0.1.0-Alpha milestone Jun 24, 2026
@Emin017 Emin017 added the bug Something isn't working label Jun 24, 2026
@Emin017 Emin017 merged commit bded101 into main Jun 24, 2026
3 checks passed
@Emin017 Emin017 deleted the emin/avoid-chmod-for-log-tests branch June 24, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant