-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Unit extensions API v2 for instructors dashboard #37783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Unit extensions API v2 for instructors dashboard #37783
Conversation
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b4b3387 to
55eef0e
Compare
- Adjust tests for more consistent behavior - Add UnitDueDateExtension as a data interface - Reduce code duplication
|
@wgu-taylor-payne I believe I’ve addressed all the comments. Could you please take another look? |
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is one more suggestion I have.
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
47a2097 to
511e8eb
Compare
…enedx#37939) Referenced GH team names have been updated accordingly as well. Closes: openedx#37904
e55a4b7 to
90896c4
Compare
wgu-taylor-payne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @holaontiveros for the initial implementation and @dwong2708 for the feedback and improvements.
@feanil Were you wanting to give this one a look over?
Description
Supporting information
fixes #37664
Testing instructions
example curl to test, make sure you have the right cookies and update the right IDs and details
a possible valid example of response of the query looks like:
{ "next": null, "previous": null, "count": 2, "num_pages": 1, "current_page": 1, "start": 0, "results": [ { "username": "armando", "full_name": "", "email": "armando.ontiveros@wgu.edu", "unit_title": "Subsection", "unit_location": "block-v1:OEXCOM+101+2025_T1+type@sequential+block@c3ccd3d1f91b42dfb2bff8185dba4d3b", "extended_due_date": "2026-12-28T00:00:00Z" }, { "username": "javier", "full_name": "", "email": "javier.ontiveros@wgu.edu", "unit_title": "Subsection", "unit_location": "block-v1:OEXCOM+101+2025_T1+type@sequential+block@c3ccd3d1f91b42dfb2bff8185dba4d3b", "extended_due_date": "2025-12-12T12:12:00Z" } ] }Deadline
None
Other information
Include anything else that will help reviewers and consumers understand the change.