Skip to content

Conversation

@dwong2708
Copy link
Contributor

@dwong2708 dwong2708 commented Jan 26, 2026

Description

During testing of the new V2 ORA List endpoint, an issue was identified in the final response: the ORA grading URL field for staff assessment was missing. Initially, it was assumed that this URL would be constructed on the frontend. However, we later determined that it should be provided by the backend, since the MFE grading URL is configured there.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 26, 2026

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 26, 2026
@dwong2708 dwong2708 changed the title fix: add missing staff_ora_grading_url field to ORA list endpoint res… fix: add missing staff_ora_grading_url field to ORA list endpoint Jan 26, 2026
@dwong2708 dwong2708 marked this pull request as ready for review January 26, 2026 16:31
@dwong2708 dwong2708 requested a review from feanil January 26, 2026 16:34
# - edx-ora2:
# https://github.com/openedx/edx-ora2/blob/801fbd14ebb059ab8c5ee8d5a39c260c7f87ab81/
# openassessment/xblock/static/js/src/lms/oa_course_items_listing.js#L73
staff_ora_grading_url = f"{ora_grading_base_url}/{block_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your example shows the URL is a courses.example.com ( ie. an LMS url instead of an MFE one) but the code here suggests that this will only work with the MFE? Is there a fallback in the old UI that is relevant here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. The example URL coming from the legacy code paths happens to be an LMS URL, but in this implementation there is no fallback to the old LMS UI.

The intent here is to always point to the ORA Grading Microfrontend. The conditional logic is preserved only to mirror the legacy instructor dashboard behavior (non-team assignments with staff assessment), not to reuse the LMS grading UI.

During and after the migration, ora_grading_base_url is expected to be configured to the MFE entry point, so this URL will always resolve to the MFE rather than courses.example.com.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the comment to better clarify the intent here. Thanks

@dwong2708 dwong2708 requested a review from feanil January 26, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants