-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: add missing staff_ora_grading_url field to ORA list endpoint #37937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| # - edx-ora2: | ||
| # https://github.com/openedx/edx-ora2/blob/801fbd14ebb059ab8c5ee8d5a39c260c7f87ab81/ | ||
| # openassessment/xblock/static/js/src/lms/oa_course_items_listing.js#L73 | ||
| staff_ora_grading_url = f"{ora_grading_base_url}/{block_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your example shows the URL is a courses.example.com ( ie. an LMS url instead of an MFE one) but the code here suggests that this will only work with the MFE? Is there a fallback in the old UI that is relevant here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The example URL coming from the legacy code paths happens to be an LMS URL, but in this implementation there is no fallback to the old LMS UI.
The intent here is to always point to the ORA Grading Microfrontend. The conditional logic is preserved only to mirror the legacy instructor dashboard behavior (non-team assignments with staff assessment), not to reuse the LMS grading UI.
During and after the migration, ora_grading_base_url is expected to be configured to the MFE entry point, so this URL will always resolve to the MFE rather than courses.example.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the comment to better clarify the intent here. Thanks
Description
During testing of the new V2 ORA List endpoint, an issue was identified in the final response: the ORA grading URL field for staff assessment was missing. Initially, it was assumed that this URL would be constructed on the frontend. However, we later determined that it should be provided by the backend, since the MFE grading URL is configured there.