chore: update readme for verawood dependency#38509
chore: update readme for verawood dependency#38509kdmccormick merged 1 commit intoopenedx:release/verawoodfrom
Conversation
|
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| --------------------- | ||
|
|
||
| * Frozen at the time of the Verawood release | ||
| * Supports Python 3.11 and Python 3.12 |
There was a problem hiding this comment.
| * Supports Python 3.11 and Python 3.12 | |
| * Supports Python 3.12 |
we dropped 3.11 support from the codejail package itself, so this the env will only support 3.12 in verawood
There was a problem hiding this comment.
Should I add that we dropped support for 3.11?
There was a problem hiding this comment.
yeah, good idea, we noted it as a breaking change when we dropped 3.8
| to newer versions. These upgrades continue improvements for Python 3.12 | ||
| compatibility and include minor dependency refreshes. |
There was a problem hiding this comment.
| to newer versions. These upgrades continue improvements for Python 3.12 | |
| compatibility and include minor dependency refreshes. | |
| to newer versions. These upgrades continue improvements for Python 3.12 | |
| compatibility and include minor dependency refreshes. |
in rst, following lines need to match the indentation of the bullet
5e27f42 to
180b321
Compare
kdmccormick
left a comment
There was a problem hiding this comment.
LGTM as long as you check that it renders correctly first :)
| * Frozen at the time of the Verawood release | ||
| * BREAKING CHANGE: Drops support for Python 3.11 | ||
| * Supports Python 3.12 | ||
| * NumPy is upgraded to 1.26.4 | ||
| * SciPy is upgraded to 1.17.1 | ||
| * Several other libraries (such as matplotlib, nltk, sympy) have also been updated | ||
| to newer versions. These upgrades continue improvements for Python 3.12 | ||
| compatibility and include minor dependency refreshes. |
There was a problem hiding this comment.
The indentation is still off. I think this will fix it, please use the Preview / View File tab to check that it looks right!
| * Frozen at the time of the Verawood release | |
| * BREAKING CHANGE: Drops support for Python 3.11 | |
| * Supports Python 3.12 | |
| * NumPy is upgraded to 1.26.4 | |
| * SciPy is upgraded to 1.17.1 | |
| * Several other libraries (such as matplotlib, nltk, sympy) have also been updated | |
| to newer versions. These upgrades continue improvements for Python 3.12 | |
| compatibility and include minor dependency refreshes. | |
| * Frozen at the time of the Verawood release | |
| * BREAKING CHANGE: Drops support for Python 3.11 | |
| * Supports Python 3.12 | |
| * NumPy is upgraded to 1.26.4 | |
| * SciPy is upgraded to 1.17.1 | |
| * Several other libraries (such as matplotlib, nltk, sympy) have also been updated | |
| to newer versions. These upgrades continue improvements for Python 3.12 | |
| compatibility and include minor dependency refreshes. |
There was a problem hiding this comment.
🙈 let me fix my editor for it, I am really sorry to get so many re-edits for a small change.
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
180b321 to
4928234
Compare
|
@farhaanbukhsh This edx-sandbox freezing is meant to be done before the release cutoff, so that future releases will have verawood.txt. Could you forward-port verawood.txt and this readme update to master? |
|
@kdmccormick sure, I made the PR before but forgot to merge it 🙈 |
Update the readme for sandbox requirement for verawood.