Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Sep 22, 2025

Description

Removing React imports that are not required anymore on newer versions. Some of the imports were deconstructed to remove the usage of the global React object.
Most of the modifications were performed using the react/update-react-imports codemod.
Also modified the babel config file to use the JSX Transform (introduced in React 17).
Partially closes #3796
Components included:

  • src/ActionRow
  • src/Alert
  • src/Annotation
  • src/asInput
  • src/Avatar
  • src/AvatarButton
  • src/Badge
  • src/Breadcrumb
  • src/Bubble
  • src/Button

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 22, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6de26ce
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/68de947df8d18c0008b9d027
😎 Deploy Preview https://deploy-preview-3808--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.18%. Comparing base (63e8704) to head (9bdea01).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.x    #3808   +/-   ##
=============================================
  Coverage         94.18%   94.18%           
=============================================
  Files               242      242           
  Lines              4248     4248           
  Branches            982      982           
=============================================
  Hits               4001     4001           
  Misses              239      239           
  Partials              8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Sep 23, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Ready for Review in Contributions Sep 23, 2025
@mphilbrick211
Copy link

Hi @jacobo-dominguez-wgu! Looks like there's some branch conflicts, would you mind taking a look?

…> and <IconButton> (openedx#3789)

* refactor: remove propTypes and defaultProps Chip

* refactor: remove propTypes and defaultProps Toast

* refactor: remove propTypes and defaultProps FormLabel

* refactor: remove propTypes and defaultProps IconButton

* fix: changing docstring, hardcoding default values

* fix: iconButton forwardedref syntax

* chore: add missing default value for iconButton

* chore: address feedback on docs

* chore: address feedback on docs

* docs: add links to type definition

* docs: add back deprecated comment for icon FA
Co-authored-by: adamstankiewicz <2828721+adamstankiewicz@users.noreply.github.com>
@brian-smith-tcril
Copy link
Contributor

@jacobo-dominguez-wgu the deploy previews on these weren't working because of an issue on the release-23.x branch. That has been fixed by #3835. Would you be able to rebase them?

@jacobo-dominguez-wgu
Copy link
Contributor Author

@jacobo-dominguez-wgu the deploy previews on these weren't working because of an issue on the release-23.x branch. That has been fixed by #3835. Would you be able to rebase them?

Thanks! I was struggling to find out why were failing.

@brian-smith-tcril
Copy link
Contributor

Something odd seems to have happened here, the commits tab is showing 8 commits, including ones that have already landed in release-23.x - could you try the rebase again?

There is some good news too though! CI is catching the build error on this one now.

@jacobo-dominguez-wgu
Copy link
Contributor Author

Already rebase with release-23.x twice and and commits already landed are still showing here, I am closing this and creating a new pr to get rid of those #3840

@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove unnecessary React imports

6 participants