-
Notifications
You must be signed in to change notification settings - Fork 91
removing unnecessary react imports part 1 #3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing unnecessary react imports part 1 #3808
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3808 +/- ##
=============================================
Coverage 94.18% 94.18%
=============================================
Files 242 242
Lines 4248 4248
Branches 982 982
=============================================
Hits 4001 4001
Misses 239 239
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @jacobo-dominguez-wgu! Looks like there's some branch conflicts, would you mind taking a look? |
…into removing-react-imports-1
…> and <IconButton> (openedx#3789) * refactor: remove propTypes and defaultProps Chip * refactor: remove propTypes and defaultProps Toast * refactor: remove propTypes and defaultProps FormLabel * refactor: remove propTypes and defaultProps IconButton * fix: changing docstring, hardcoding default values * fix: iconButton forwardedref syntax * chore: add missing default value for iconButton * chore: address feedback on docs * chore: address feedback on docs * docs: add links to type definition * docs: add back deprecated comment for icon FA
Co-authored-by: adamstankiewicz <2828721+adamstankiewicz@users.noreply.github.com>
|
@jacobo-dominguez-wgu the deploy previews on these weren't working because of an issue on the |
Thanks! I was struggling to find out why were failing. |
|
Something odd seems to have happened here, the commits tab is showing 8 commits, including ones that have already landed in There is some good news too though! CI is catching the build error on this one now. |
|
Already rebase with release-23.x twice and and commits already landed are still showing here, I am closing this and creating a new pr to get rid of those #3840 |
Description
Removing React imports that are not required anymore on newer versions. Some of the imports were deconstructed to remove the usage of the global React object.
Most of the modifications were performed using the react/update-react-imports codemod.
Also modified the babel config file to use the JSX Transform (introduced in React 17).
Partially closes #3796
Components included:
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?Post-merge Checklist