-
Notifications
You must be signed in to change notification settings - Fork 90
fix: fix error with hidden content for data table #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-23.x
Are you sure you want to change the base?
fix: fix error with hidden content for data table #4046
Conversation
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4046 +/- ##
=============================================
Coverage 94.39% 94.39%
=============================================
Files 242 242
Lines 4296 4301 +5
Branches 981 1024 +43
=============================================
+ Hits 4055 4060 +5
+ Misses 237 233 -4
- Partials 4 8 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| render(<TableRowWrapper value={{}} row={{ ...props, isExpanded: true }} />); | ||
| const rows = screen.getAllByRole('row'); | ||
| expect(rows.length).toEqual(1); | ||
| expect(container.querySelector('div')).not.toBeInTheDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before changes in TableCell, the test checks container.querySelector('div') and expects no div, but now TableCell always creates a div with class pgn__data-table-cell-wrap for regular columns.
Let's update this test so that it checks for the absence of a second row (subcomponent) rather than the absence of any div.
Description
A fix is added to the DataTable component to properly handle content overflow within table cells
Issue
#4001
Changes
Before
After
How to test it
You can add this code in to this file
src/DataTable/README.mdand view local how does it work`