Open
Conversation
d-jeffery
force-pushed
the
fix/condition-validation
branch
from
4ba8caa to
9403bab
Compare
senojj
reviewed
Aug 15, 2024
| string name = 1 [ | ||
| (validate.rules).string = { | ||
| pattern: "^[^\\s]{2,256}$" | ||
| pattern: "^[^\\s]{1,50}$" |
There was a problem hiding this comment.
is there a specific byte length that we are targeting, or are we only concerned about character count? Considering byte length, a maximum of 200 bytes (UTF-8 4-byte characters) would be valid for 50 characters.
if the assumption is that we are limiting to 50 8-bit characters for a maximum of 50 bytes, then more validations will need to be put into place.
senojj
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restrict character limit of condition down to 50 characters. Left the patterns as they were.
References
openfga/language#319
Review Checklist
main