fix: swap action used for validating swagger file#242
Conversation
WalkthroughThe PR updates the GitHub Actions workflow to replace the swagger-editor-validate action with apidom-validate. The change includes updating the action reference, modifying the definition-file parameter format to use single quotes, and adding a fails-on threshold parameter set to 1 to trigger failure on any validation error. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
25ab9f9 to
c25358d
Compare
Signed-off-by: José Padilla <jose.padilla@okta.com>
c25358d to
7ec00de
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing OpenAPI/Swagger validation step in the GitHub Actions workflow by switching to a different validation action.
Changes:
- Replaced
swaggerexpert/swagger-editor-validatewithswaggerexpert/apidom-validateaction - Added
fails-on: 1parameter to configure failure behavior - Updated definition file path to use single quotes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/review.yaml:
- Around line 44-47: Replace the non-existent action reference and invalid
input: change the action name
"swaggerexpert/apidom-validate@e5f5f23a9258709b041cf2b8d7040858057fface" to the
correct "swaggerexpert/swagger-editor-validate" (or, if you need ApiDOM
specifically, use "char0n/apidom-validate") and replace the unsupported
"fails-on" parameter with the correct input name "ignore-error" for
swagger-editor-validate; update the action invocation that uses definition-file
and its inputs accordingly so the workflow calls a valid action and uses valid
input keys.
Description
What problem is being solved?
Failures validating openapi swagger file https://github.com/openfga/api/actions/runs/21225752933/job/61082841107?pr=241
How is it being solved?
Switched github action used for that step.
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.