Added docx to pdf converter#147
Draft
SteRiccio wants to merge 6 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a DOCX→PDF conversion utility to the server codebase and exposes it via the existing utils and package entrypoint exports.
Changes:
- Added
DocxConverter.convertDocxToPdfthat usesmammoth(DOCX→HTML) +puppeteer(HTML→PDF). - Exported
DocxConverterthroughsrc/utils/index.tsandsrc/index.ts. - Added new runtime dependencies (
mammoth,puppeteer) and updated lockfile accordingly.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/docxConverter.ts |
New DOCX-to-PDF converter implementation using Mammoth + Puppeteer. |
src/utils/index.ts |
Re-exports the new DocxConverter utility. |
src/index.ts |
Exposes DocxConverter from the package entrypoint. |
package.json |
Adds mammoth and puppeteer runtime dependencies. |
yarn.lock |
Lockfile updates for the new dependencies and transitive upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Comment on lines
+11
to
+15
| const pageLoadTimeoutMs = 15000 | ||
| const parsedMaxConcurrency = Number(process.env.DOCX_PDF_MAX_CONCURRENCY ?? 2) | ||
| const maxPdfConversionsInParallel = | ||
| Number.isFinite(parsedMaxConcurrency) && parsedMaxConcurrency > 0 ? Math.floor(parsedMaxConcurrency) : 2 | ||
|
|
Comment on lines
+49
to
+56
| const launchBrowser = async (): Promise<Awaited<ReturnType<typeof puppeteer.launch>>> => { | ||
| const forceNoSandbox = process.env.PUPPETEER_NO_SANDBOX === 'true' | ||
|
|
||
| if (forceNoSandbox) { | ||
| return puppeteer.launch({ | ||
| headless: true, | ||
| args: ['--no-sandbox', '--disable-setuid-sandbox'], | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.