fix(security): 2 improvements across 2 files#377
Open
tomaioo wants to merge 2 commits into
Open
Conversation
- Security: Management API can be accessed without authentication if management port is reachable - Security: Command injection risk from spawning commands with `shell: true` Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Management API can be accessed without authentication if management port is reachable - Security: Command injection risk from spawning commands with `shell: true` Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
Critical| File:modules/app-launcher/src/main.js:L47The management server is started directly on
managementPortwith sensitive routes (restart/update/pull/build-restart) but no authentication middleware is applied at that server level. Authentication is only enforced in the main server proxy path/management. If the management port is exposed (container/network misconfiguration, host port mapping, internal lateral movement), attackers can call privileged endpoints directly.Solution
Enforce authorization on the management server itself (defense in depth), and bind the management server to localhost/internal interface only. Additionally, restrict network exposure via firewall/container networking and require strong auth (e.g., token/mTLS) for all management routes.
Changes
modules/app-launcher/src/main.js(modified)lib/js/shared/src/terminal.js(modified)