-
Notifications
You must be signed in to change notification settings - Fork 707
Lobby chat panel #2514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Phantasm0009
wants to merge
25
commits into
openfrontio:main
Choose a base branch
from
Phantasm0009:lobby-chat-panel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lobby chat panel #2514
Changes from 6 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9570fe2
feat: add in-lobby chat panel for private games
Phantasm0009 64d269b
chore: fix husky pre-commit and eslint mock inclusion
Phantasm0009 f31a3b0
fix: enforce 300-char limit and add __mocks__ to tsconfig
Phantasm0009 546b608
fix(lobby-chat): scroll after render, improve send failure UX, and na…
Phantasm0009 4894fa4
fix(lobby-chat): prevent default & stop propagation on Enter key
Phantasm0009 0d83cf8
Merge branch 'main' into lobby-chat-panel
Phantasm0009 17647d4
revert: remove unrelated StructureIconsLayer changes from lobby-chat PR
Phantasm0009 b16587d
fix: update OutlineFilter to use @pixi/filter-outline API
Phantasm0009 a806606
Merge branch 'main' into lobby-chat-panel
Phantasm0009 8a2056e
fix(deps): migrate to pixi-filters v6 for PixiJS v8 compatibility
Phantasm0009 9a5628d
Merge branch 'main' into lobby-chat-panel
Phantasm0009 f97d5c6
Fix clients able to join above max players (#2547)
Lavodan 7de7f24
Add the Lisbon Map and Credit Copernicus DEM (#2545)
jachisc 40be1d6
Fixes lobby team preview: clan players aren't assigned a team + add n…
VariableVince f241ac0
Correct Gulf of St. Lawrence map (#2555)
jachisc 1ce87d2
fix failing nationNameLength test (#2556)
Lavodan dec23ce
Fix: firefox back button not working (#2557)
Lavodan df3e5d7
Special bot names (#2552)
VariableVince d0a047b
Fix spacing in player team label display (#2560)
VariableVince 93cf256
Alert frame: add to in-game settings, orange for attack instead of re…
VariableVince d933b25
refactor: address code review feedback for lobby chat feature
Phantasm0009 7a28c49
Merge branch 'main' into lobby-chat-panel
Phantasm0009 255a767
fix: update ServerLobbyChatSchema to use username and isHost fields
Phantasm0009 762ac48
feat: improve lobby chat UX with local/remote message styling
Phantasm0009 254469d
fix: use lobbyConfig.playerName instead of undefined lobby variable
Phantasm0009 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
| # Husky v10 compatible pre-commit (removed deprecated husky.sh sourcing) | ||
| # Ensure PATH includes typical Node locations if needed (optional on most setups) | ||
| export PATH="$PATH" | ||
|
|
||
| # Add PATH setup to ensure npx is found | ||
| export PATH="/usr/local/bin:$HOME/.npm-global/bin:$HOME/.nvm/versions/node/$(node -v)/bin:$PATH" | ||
|
|
||
| # Then run lint-staged if tests pass | ||
| # Run lint-staged tasks | ||
| npx lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Minimal mock of jose for tests | ||
| export const base64url = { | ||
| encode: (input) => Buffer.from(String(input)).toString("base64url"), | ||
| decode: (input) => Buffer.from(String(input), "base64url").toString("utf8"), | ||
| }; | ||
| export const jwtVerify = async () => ({ payload: {}, protectedHeader: {} }); | ||
| export const decodeJwt = () => ({ sub: "test" }); | ||
| export const JWK = {}; | ||
Phantasm0009 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its being used to mock the jose library for testing and its configured in the jest.config,test. Its imported by TestServerConfig.ts and it provides mock implementations for JWT functions during tesing.