-
Notifications
You must be signed in to change notification settings - Fork 42
add redirect_uri to Credential Offer
#759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paulbastian
wants to merge
16
commits into
main
Choose a base branch
from
pb/redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9677a51
add `redirect_uri` to Credential Offer
paulbastian e127cca
Apply suggestion from wg discussion
paulbastian 293a9a6
Apply suggestions from code review
paulbastian 756809a
Apply suggestion from @paulbastian
paulbastian 636ee78
Merge branch 'main' into pb/redirect
paulbastian 92842de
Fix Credential Offer parameter description
paulbastian 86ecefe
Apply suggestions from code review
paulbastian d5875ce
Apply suggestion from @jogu
paulbastian 9cc226e
Apply suggestion from @paulbastian
paulbastian 1cd33ec
Apply suggestion from @paulbastian
paulbastian 9bf2345
rename expected_redirect_origin to expected_redirect_origins
paulbastian b1fee80
Apply suggestion from @paulbastian
paulbastian 415c797
remove issuer_state parameter from redirect_uri
paulbastian d14ad13
minor fixes
paulbastian 765bf58
add security consideration for redirect_uri
paulbastian cee9e79
clarification on which user agent is used on redirect_uri
paulbastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these editorial changes move these two lines further down, which currently split the grants parameter from the grants values