Add additional text clarifying how to match vct and doctype - #744
Add additional text clarifying how to match vct and doctype#744GarethCOliver wants to merge 10 commits into
Conversation
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
|
WG discussion: makes sense to have this in errata, too and also not to limit validation rules to the wallet but also verifier. |
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
|
WG discussion suggests: Make sure it is clear this is an optional feature. @c2bo will propose text. |
Co-authored-by: Frederik Krogsdal Jacobsen <fkj@users.noreply.github.com>
|
From conversation at IETF: SD-JWT-VC intends to add a claim to make it explicit what the super-types of a particular credential are (which will make this trivial and correct). Until that is in place we shouldn't update this text, and should update to reference it when it is ready. Note that the part of this PR related to mdoc can still go through. |
|
Updated text to reference the |
| When a Wallet or Verifier needs to determine whether a Credential's type satisfies a Credential Query, it MUST do so by evaluating if at least one of the following true: | ||
|
|
||
| 1. The value of the `vct` claim in the Credential is contained in the `vct_values` array. | ||
| 1. The `aka_vcts` claim is present and has at least one element that is contained in the `aka_vcts` array. |
There was a problem hiding this comment.
Did you mean?
| 1. The `aka_vcts` claim is present and has at least one element that is contained in the `aka_vcts` array. | |
| 1. The `aka_vcts` claim is present and has at least one element that is contained in the `vct_values` array. |
There was a problem hiding this comment.
I think if we make this change we have to make it in 1.0 as well - otherwise it's a breaking change in 1.1 and/or 1.0 and 1.1 differ in core behaviour.
But we need to come to a conclusion on #726 first really. If 1.0 is going to reference the latest SD-JWT spec then really 1.0 is going to gain this behaviour regardless, and if we agree on that then making it explicit in 1.0 is best.
(The actual changes in this PR do seem like a sensible way of addressing the problem.)
Resolves #741 by adding more explicit instructions on what allows a Credential to satisfy
vct_values, and applies similar explicit text todoctype_valueThis makes use of the SD-JWT VC draft 15 which added
aka_vctsfor this purpose