8373716: Refactor further java/util tests from TestNG to JUnit#2655
8373716: Refactor further java/util tests from TestNG to JUnit#26550zzy0sbourne wants to merge 1 commit into
Conversation
|
👋 Welcome back 0zzy0sbourne! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
e8a89da to
5bd8ec9
Compare
|
/test |
|
Based on the CI logs, the reason for failures in windows-aarch64 and windows-x64 builds seems like unrelated to this backport, both failing during the hotspot build phase before any test code is involved:
|
|
@0zzy0sbourne This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
|
@0zzy0sbourne this pull request can not be integrated into git checkout JDK-backport-8373716
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Backporting JDK-8373716: Refactor further java/util tests from TestNG to JUnit
This PR backports the migration of 14 test files across java.util.Calendar, java.util.TimeZone,
java.util.Properties, and java.util.ResourceBundle from TestNG to JUnit Jupiter, as part of the broader
JDK-8307843 effort to standardize the JDK test suite on JUnit.
make test TEST=test/jdk/java/util/Calendar/CalendarDisplayNamesTest.java
make test TEST=test/jdk/java/util/Calendar/JapaneseLenientEraTest.java
make test TEST=test/jdk/java/util/Calendar/SupplementalJapaneseEraTestRun.java
make test TEST=test/jdk/java/util/Properties/CompatibilityTest.java
make test TEST=test/jdk/java/util/Properties/EncodingTest.java
make test TEST=test/jdk/java/util/Properties/InitialCapacity.java
make test TEST=test/jdk/java/util/Properties/PropertiesEntrySetTest.java
make test TEST=test/jdk/java/util/Properties/PropertiesStoreTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/basic/BasicTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/cache/CacheTest.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/casesensitive/CaseInsensitiveNameClash.java
make test TEST=test/jdk/java/util/ResourceBundle/modules/visibility/VisibilityTest.java
make test TEST=test/jdk/java/util/TimeZone/NegativeDSTTest.java
make test TEST=test/jdk/java/util/TimeZone/ZoneIdRoundTripTest.java
Results:
TEST SUCCESS — 14/14 passed, 0 failures, 0 errors
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2655/head:pull/2655$ git checkout pull/2655Update a local copy of the PR:
$ git checkout pull/2655$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2655/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2655View PR using the GUI difftool:
$ git pr show -t 2655Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2655.diff