8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient#2888
8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient#2888rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8310645: CancelledResponse.java does not use HTTP/2 when testing the HttpClient.
This PR adds an HTTP/2 test for cancelling a BodySubscriber while receiving data.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/net/httpclient/CancelledResponse2.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2888/head:pull/2888$ git checkout pull/2888Update a local copy of the PR:
$ git checkout pull/2888$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2888/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2888View PR using the GUI difftool:
$ git pr show -t 2888Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2888.diff
Using Webrev
Link to Webrev Comment