8371967: Add Visual Studio 2026 to build toolchain for Windows#2892
8371967: Add Visual Studio 2026 to build toolchain for Windows#2892antonvoznia wants to merge 3 commits into
Conversation
|
👋 Welcome back antonvoznia! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/issue JDK-8373593 |
|
@antonvoznia |
phohensee
left a comment
There was a problem hiding this comment.
Looks like the only reason the bot wanted a review was because the PR combines two JBS issues.
|
|
|
/approval JDK-8371967 request jdk21u-dev . Clean backport, only VS 2026 references in doc/building.md were adjusted manually due to a different text format. Motivation: VS 2026 is now Microsoft's default download, and toolchain fixes land there first while VS 2022 backports lag. Keeping JDK 21 (LTS) buildable with current tooling matters more over time. Risk: Low. Additive change, VS 2026 appended to VALID_VS_VERSIONS, VS 2019/2022 builds unaffected. Validated locally on Windows x64: configure, build, tier-1 tests, no regressions. |
|
@antonvoznia |
|
/approval JDK-8373593 request jdk21u-dev, additional clean backport of fix that should be integrated with JDK-8371967: Add Visual Studio 2026 to build toolchain for Windows |
|
@antonvoznia |
Clean backport. Only the VS 2026 references in
doc/building.mdwere changed manually because of a different text format.Problem this solves:
The build system currently rejects newer Visual Studio versions that we increasingly need to use:
Risk assessment:
Low risk. The change is additive: it appends VS 2026 to the VALID_VS_VERSIONS list, so existing VS 2019/2022 builds are unaffected. I have validated the backport locally by configuring and building JDK 21 on Windows x64 with VS 2026 and running tier-1 tests (no regression).
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2892/head:pull/2892$ git checkout pull/2892Update a local copy of the PR:
$ git checkout pull/2892$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2892/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2892View PR using the GUI difftool:
$ git pr show -t 2892Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2892.diff
Using Webrev
Link to Webrev Comment