docs(logging): add attributes format convention #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efrank-at-sap
force-pushed
the
fix/logging_documentation
branch
from
9075cc9 to
e747006
Compare
bkieling
approved these changes
Jan 14, 2026
Contributor
bkieling
left a comment
bkieling
left a comment
There was a problem hiding this comment.
LGTM, just one small comment.
pkg/logger/logging.md
Outdated
Comment on lines
223
to
224
| - Always use `camelCase` format for all log attributes** to ensure consistency across teams. | ||
| - Use common attributes (`requestId`, `tenantId`) as first-level citizens** (not nested) when applicable. |
Contributor
There was a problem hiding this comment.
Could you check the 2 single closing markup occurrences of ** here.
efrank-at-sap
force-pushed
the
fix/logging_documentation
branch
from
e747006 to
4ee9c3f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging attributes format convention to enforce camelCase across all services.