go e2b sdk support custom HTTP client and extend sandbox params#38
go e2b sdk support custom HTTP client and extend sandbox params#38ZhaoQing7892 wants to merge 2 commits into
Conversation
ZhaoQing7892
commented
Jul 13, 2026
- Add CustomHTTPClient option to e2b SDK for flexible transport configuration
- Add extended parameters to sandbox query
- Add CustomHTTPClient option to e2b SDK for flexible transport configuration - Add extended parameters to sandbox query
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| MemoryMB: sb.GetMemoryMB(), | ||
| DiskSizeMB: sb.GetDiskSizeMB(), | ||
| EnvdVersion: sb.GetEnvdVersion(), | ||
| State: string(sb.GetState()), |
There was a problem hiding this comment.
The new VolumeMounts field was added to SandboxInfo (line 28), and the API response type SandboxesGet200ResponseInner includes VolumeMounts (with a GetVolumeMounts() getter). However, convertToSandboxInfo never copies it, so the field will always be empty/nil in List results.
In addition, GetInfo does not populate VolumeMounts either
| req := s.apiClient.SandboxesApi.V2SandboxesGet(ctx) | ||
|
|
||
| if len(opts) > 0 { | ||
| o := opts[0] |
There was a problem hiding this comment.
why choose only the first opts?
There was a problem hiding this comment.
The params is ...ListSandboxOpts optional
| State string | ||
| SandboxID string | ||
| TemplateID string | ||
| Alias string |
There was a problem hiding this comment.
Alias is never populated in the code