fix: enqueue reconcile when sandbox pod deletion starts#640
fix: enqueue reconcile when sandbox pod deletion starts#640ashnaaseth2325-oss wants to merge 1 commit into
Conversation
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 80.08% 80.03% -0.06%
==========================================
Files 229 229
Lines 17831 17840 +9
==========================================
- Hits 14280 14278 -2
- Misses 2969 2978 +9
- Partials 582 584 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SUMMARY
This PR ensures the Sandbox controller reconciles as soon as an agent Pod enters the terminating state. Previously, update events that only set
DeletionTimestampwere ignored, delaying Sandbox status updates until the Pod was fully deleted.The change is limited to
pkg/controller/sandbox/pod_event_handler.goand its corresponding unit tests inpkg/controller/sandbox/pod_event_handler_test.go.FIX