Skip to content

FHIR R4: normalize CodeableConcept codings and HL7 escapes; add tests #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Where-Mental-Wellness-Meets-Metaverse wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FHIR R4: normalize CodeableConcept codings and HL7 escapes; add tests #577

Where-Mental-Wellness-Meets-Metaverse wants to merge 2 commits into from

Conversation

@Where-Mental-Wellness-Meets-Metaverse
Copy link

@Where-Mental-Wellness-Meets-Metaverse Where-Mental-Wellness-Meets-Metaverse commented Aug 24, 2025 •
edited
Loading

What I changed

  • Added FhirNormalizationUtils to trim CodeableConcept codings and decode HL7 v2 escapes (\F\ → |, \S\ → ^, \T\ → &, \R\ → ~, \E\ → ).
  • Added unit test FhirNormalizationUtilsTest.

Why

  • Prevents stray whitespace and HL7 escape sequences from leaking into FHIR R4 resources.

Tests

  • FhirNormalizationUtilsTest passes locally.

Notes

  • Java 17 used.

sherrif10
sherrif10 reviewed Sep 10, 2025
View reviewed changes
api/src/main/java/org/openmrs/module/fhir2/api/util/FhirNormalizationUtils.java
*
* Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
* graphic logo is a trademark of OpenMRS Inc.
*/
Copy link
Member

@sherrif10 sherrif10 Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organize this comments . Ensure they are on the same line.

sherrif10
sherrif10 reviewed Sep 10, 2025
View reviewed changes
.mvn/jvm.config
@@ -0,0 +1,4 @@
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
Copy link
Member

@sherrif10 sherrif10 Sep 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need mvn configurations. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sherrif10 sherrif10 sherrif10 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Where-Mental-Wellness-Meets-Metaverse @sherrif10