O3-5445: Fix duplicate SQL query in AbstractBaseQueueDaoImpl#get(String uuid)#94
Open
sanks011 wants to merge 3 commits intoopenmrs:mainfrom
Conversation
…SQL query on every UUID lookup
…SQL query on every UUID lookup
…ecutes-duplicate-sql-query-on-every-uuid-lookup' of https://github.com/sanks011/openmrs-module-queue into O3-5445-abstract-base-queue-dao-impl-get-string-uuid-executes-duplicate-sql-query-on-every-uuid-lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AbstractBaseQueueDaoImpl#get(String uuid)was callingcriteria.add(eq("uuid", uuid)).uniqueResult()twice on the same mutableCriteriaobject - firing two SQL queries per UUID lookup and adding a redundant duplicateWHERE uuid = ?clause on the second query.This affected every UUID-based entity lookup across the module (
QueueEntry,Queue,QueueRoom,RoomProviderMap).Fix removes the orphaned first call and keeps a single
criteria.add(...) → uniqueResult()chain.Related
https://openmrs.atlassian.net/jira/software/c/projects/O3/boards/37?selectedIssue=O3-5445