REPORT-806 : Upgraded RunReportListController and RunReportFormController to utilize annotations#175
REPORT-806 : Upgraded RunReportListController and RunReportFormController to utilize annotations#175dilanthas wants to merge 1 commit intoopenmrs:masterfrom
Conversation
| import org.springframework.validation.ValidationUtils; | ||
| import org.springframework.validation.Validator; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
There was a problem hiding this comment.
@dkayiwa This class was removed as the validator logic added back to the controller
|
@dilanthas are all changes in this pull request required because of a mere switch to using annotations? |
|
|
It is easier to review pull requests that do just one thing. For instance, any improvements that are not related to annotations can be done using a separate ticket and pull request. https://opensource.com/article/18/6/anatomy-perfect-pull-request |
@dkayiwa I have added back the validation logic into the controller. But the other change (moving the CommandObject outside from the controller ) is required to make this work. It cannot be a subclass of the Controller otherwise it will give error |
|
@dkayiwa Extra things were rolled back. Now it only contains the changes related to the jira |
|
@dkayiwa anything else need to be fixed in order to merge this ? |
|
@mseaton Will you be able to review this please ? |
| import org.springframework.web.servlet.mvc.BaseCommandController; | ||
| import org.springframework.web.servlet.mvc.SimpleFormController; | ||
| import org.springframework.web.servlet.view.RedirectView; | ||
| import org.springframework.validation.*; |
There was a problem hiding this comment.
@dilanthas do you still have time to replace the wildcard import as advised at? https://wiki.openmrs.org/display/docs/Java+Conventions#JavaConventions-Donotusewildcardimports
3 participants
Ticket : https://issues.openmrs.org/browse/REPORT-806
What i have done : RunReportListController and RunReportFormController were using depricated SimpleFormController. i have modified the two controllers to use annotations.