REPORT-495: Added an onkeyup event to the Widgets and Text input elem…#205
Open
IamMujuziMoses wants to merge 2 commits intoopenmrs:masterfrom
Open
REPORT-495: Added an onkeyup event to the Widgets and Text input elem…#205IamMujuziMoses wants to merge 2 commits intoopenmrs:masterfrom
IamMujuziMoses wants to merge 2 commits intoopenmrs:masterfrom
Conversation
…ents which disables and enables the smallButtons when the input elements have or don't have input respectively
|
@IamMujuziMoses Thanks for working on this,can you make one pr for this instead of having two! |
Author
|
@HerbertYiga I made changes to two different modules; the reporting module and the htmlwidgets module and I don't know yet how to make one pull request for two different modules |
Author
|
@HerbertYiga is there anything more to do to this PR? @k-joseph @davidpalacios @dkayiwa requesting review on this |
Member
|
@IamMujuziMoses are you still able to reproduce this problem on this server? https://qa-refapp.openmrs.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ents which disables and enables the smallButtons when the input elements have or don't have input respectively
https://issues.openmrs.org/browse/REPORT-495