Open
Conversation
…ended doses (NCRMLoss): crmPack vs. SAS
…ended doses (NCRMLoss): crmPack vs. SAS
Merge branch 'test-sas-results' of github.com:Roche/crmPack into test-sas-results # Conflicts: # tests/testthat/test-sas-results.R
Merge branch 'test-sas-results' of github.com:Roche/crmPack into test-sas-results # Conflicts: # tests/testthat/test-sas-results-part-1.R
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: b2ba80b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 4a87aec ♻️ This comment has been updated with latest results. |
Collaborator
danielinteractive
left a comment
danielinteractive
left a comment
There was a problem hiding this comment.
thanks @marlenesg , nice work (and nice small PR!! Great!) - on top of comments below, can you please add test(s)?
| ) | ||
| setMethod( | ||
| f = "profiles", | ||
| signature = signature(x = "Data", xNE = "data.frame", unit = "character"), |
Collaborator
There was a problem hiding this comment.
how about another name instead of xNE ? e.g. x_not_eval?
| p <- ggplot(data = df) + | ||
| geom_point( | ||
| aes( | ||
| x = factor(ID, levels = unique(ID[order(cohort, ID)])), |
Collaborator
There was a problem hiding this comment.
I think we might need to work with
Suggested change
| x = factor(ID, levels = unique(ID[order(cohort, ID)])), | |
| x = factor(.data$ID, levels = unique(.data$ID[order(.data$cohort, .data$ID)])), |
etc. to avoid R CMD check notes about missing global variables, please double check the R CMD check output
Comment on lines
+174
to
+177
| scale_shape_manual(values = c( | ||
| "DLT No" = 19, "DLT Yes" = 17, | ||
| "Not evaluable" = 0 | ||
| ), drop = FALSE) + |
Collaborator
There was a problem hiding this comment.
I would recommend making this configurable by the user, i.e. here:
Suggested change
| scale_shape_manual(values = c( | |
| "DLT No" = 19, "DLT Yes" = 17, | |
| "Not evaluable" = 0 | |
| ), drop = FALSE) + | |
| scale_shape_manual(values = scale_shape_values, drop = FALSE) + |
and in the arguments of this method
scale_shape_values = c(
"DLT No" = 19, "DLT Yes" = 17,
"Not evaluable" = 0
)
so that the user can keep defaults, or modify this
| "Not evaluable" = 0 | ||
| ), drop = FALSE) + | ||
| scale_color_manual( | ||
| values = c( |
Collaborator
There was a problem hiding this comment.
same idea also here
Comment on lines
+196
to
+203
| theme_bw() + | ||
| theme(plot.title = element_text(hjust = 0.5)) + | ||
| theme(legend.title = element_blank()) + | ||
| theme( | ||
| legend.background = element_blank(), | ||
| legend.box.background = element_rect(colour = "black"), | ||
| axis.text.x = element_text(angle = 45, hjust = 1) | ||
| ) |
Collaborator
There was a problem hiding this comment.
I would keep the theme modifiable by the user.
options:
- completely omit this here to just use the default theme
- if that does not look ok, then define a
theme_profilesfunction that returns this and in this method have argumenttheme = theme_profiles()that is then used here, but the user could modify it
Collaborator
|
@marlenesg any questions / should we go through comments together? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Added the code for profile plots in Data-methods.R. I am not sure why the old changes in tests/testthat/test-sas-results-part-1.R and tests/testthat/test-sas-results-part-2.R are showing up. These changes have already been merged into the main branch previously.
Partially fixes #783