Draft
Conversation
Collaborator
danielinteractive
left a comment
danielinteractive
left a comment
There was a problem hiding this comment.
Thanks a lot @clarkliming for starting this!
Just let me know when you are ready for review
| // partial sigma / partial theta_1 = sigma. | ||
| auto sigma = this->get_sigma(visits, dist); | ||
| ret.block(0, 0, dist.rows(), dist.cols()) = sigma; | ||
| ret.block(dist.rows(), 0, dist.rows(), dist.cols()) = sigma.array() * dist.array().suqare() * (1 - this->rho); |
Collaborator
There was a problem hiding this comment.
Suggested change
| ret.block(dist.rows(), 0, dist.rows(), dist.cols()) = sigma.array() * dist.array().suqare() * (1 - this->rho); | |
| ret.block(dist.rows(), 0, dist.rows(), dist.cols()) = sigma.array() * dist.array().square() * (1 - this->rho); |
Collaborator
There was a problem hiding this comment.
this is still there
| auto dtheta1dtheta2 = sigma.array() * dist.array().suqare() * rho_r; | ||
| ret.block(dist.rows(), 0, dist.rows(), dist.cols()) = dtheta1dtheta2; | ||
| ret.block(dist.rows() * 2, 0, dist.rows(), dist.cols()) = dtheta1dtheta2; | ||
| matrix<Type> dtheta2s = dtheta1dtheta2 * (dist.array().suqare() * rho_r - this->rho); |
Collaborator
There was a problem hiding this comment.
here the typo is again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #501
this is a draft and a lot of files need to be updated; given low capacity at the moment I will need to do it slowly.
The core part is simple and has been updated; the documents, tests etc are to be completed