Skip to content

Fix: Not fetching the wildcard domain when creating CSR#5

Open
YumeChaan wants to merge 6 commits into
masterfrom
INTGRTNS-510-BE-WHMCS-SSL-Module-Not-fetching-the-wildcard-domain-when-creating-CSR
Open

Fix: Not fetching the wildcard domain when creating CSR#5
YumeChaan wants to merge 6 commits into
masterfrom
INTGRTNS-510-BE-WHMCS-SSL-Module-Not-fetching-the-wildcard-domain-when-creating-CSR

Conversation

@YumeChaan

Copy link
Copy Markdown
  • Updated CSR generation to use the entered Common Name.
  • Fixed wildcard domain support when generating CSRs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CSR token generation so the Common Name used for CSR creation can come from user input (including wildcard domains), and standardizes RSA key size to 4096 bits.

Changes:

  • Adds a Common Name input field to the CSR creation modal UI.
  • Uses the submitted Common Name when creating CSRs (client-area flow), including updating SAN behavior.
  • Changes RSA key size from an invalid 4098 to 4096 in both admin and client CSR creation flows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
modules/servers/openprovider_ssl/lib/Helper.php Updates CSR modal HTML to include a Common Name field.
modules/servers/openprovider_ssl/hooks.php Updates admin-side CSR request payload to use 4096-bit keys.
modules/servers/openprovider_ssl/classes/HandleCSRCreation.php Uses submitted common_name for CSR creation (and updates SAN) with 4096-bit keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/servers/openprovider_ssl/lib/Helper.php Outdated
Comment thread modules/servers/openprovider_ssl/lib/Helper.php Outdated
Comment thread modules/servers/openprovider_ssl/lib/Helper.php Outdated
Comment thread modules/servers/openprovider_ssl/classes/HandleCSRCreation.php Outdated
Comment thread modules/servers/openprovider_ssl/hooks.php
Comment thread modules/servers/openprovider_ssl/hooks.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants