Fix: Not fetching the wildcard domain when creating CSR#5
Open
YumeChaan wants to merge 6 commits into
Open
Conversation
YumeChaan
commented
May 27, 2026
- Updated CSR generation to use the entered Common Name.
- Fixed wildcard domain support when generating CSRs.
There was a problem hiding this comment.
Pull request overview
This PR updates CSR token generation so the Common Name used for CSR creation can come from user input (including wildcard domains), and standardizes RSA key size to 4096 bits.
Changes:
- Adds a Common Name input field to the CSR creation modal UI.
- Uses the submitted Common Name when creating CSRs (client-area flow), including updating SAN behavior.
- Changes RSA key size from an invalid
4098to4096in both admin and client CSR creation flows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
modules/servers/openprovider_ssl/lib/Helper.php |
Updates CSR modal HTML to include a Common Name field. |
modules/servers/openprovider_ssl/hooks.php |
Updates admin-side CSR request payload to use 4096-bit keys. |
modules/servers/openprovider_ssl/classes/HandleCSRCreation.php |
Uses submitted common_name for CSR creation (and updates SAN) with 4096-bit keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avishka-ra
approved these changes
Jun 11, 2026
prasad-fernando-74
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.