Add regression tests for openMocks removal with @ExtendWith#932
Closed
Add regression tests for openMocks removal with @ExtendWith#932
Conversation
Adds tests confirming that the Mockito1to3Migration and JUnit4to5Migration recipe chains correctly remove MockitoAnnotations.openMocks(this) when @ExtendWith(MockitoExtension.class) is added to a test class. Covers the scenario from moderneinc/customer-requests#2030 where having both @ExtendWith(MockitoExtension.class) and MockitoAnnotations.openMocks(this) causes double mock instantiation. Tests verify: - Simple openMocks() call in @beforeeach is removed - openMocks() with AutoCloseable field and close() in @AfterEach is removed - JUnit 4 to 5 migration path with openMocks() works end-to-end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mockito1to3MigrationandJUnit4to5Migrationcorrectly removeMockitoAnnotations.openMocks(this)when@ExtendWith(MockitoExtension.class)is addedopenMocks(),openMocks()withAutoCloseablefield +close(), and JUnit 4→5 migration pathTest plan
RemoveInitMocksIfRunnersSpecifiedtests passAddMockitoExtensionIfAnnotationsUsedtests passMockito1to3Migrationtests pass