Skip to content

Conversation

@anngineery
Copy link
Contributor

@anngineery anngineery commented Jun 27, 2025

Continuation of #14

@anngineery
Copy link
Contributor Author

@stffrdhrn I cannot add reviewers for some reason, but can you review this PR when you get a chance?

Copy link
Member

@stffrdhrn stffrdhrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

platform/qemu.md Outdated
```
3. Go inside the root directory and run configure
```
cd qemu-9.2.2 && ./configure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to limit it to openrisc? For example: --target-list="o1rk-linux-user or1k-softmmu. Also consider others we enable here: https://github.com/stffrdhrn/or1k-utils/blob/master/qemu/config.qemu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added target-list and softmmu for now. I didn't know about this, where can I read and learn more about these options?

@stffrdhrn
Copy link
Member

Hi @anngineery I would like to merge this did you see my latest comments?

@anngineery
Copy link
Contributor Author

Hey @stffrdhrn, I didn't get a chance to look at it until now. working on it!

@anngineery anngineery requested a review from stffrdhrn July 14, 2025 15:20
@anngineery
Copy link
Contributor Author

anngineery commented Jul 14, 2025

@stffrdhrn if you are happy with it, feel free to merge it

@stffrdhrn stffrdhrn merged commit 39a0dfc into openrisc:master Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants