fix(compliance): align rule reference and framework mappings#130
Open
m-khan-97 wants to merge 1 commit into
Open
fix(compliance): align rule reference and framework mappings#130m-khan-97 wants to merge 1 commit into
m-khan-97 wants to merge 1 commit into
Conversation
Collaborator
Author
|
CI is green. This PR is ready for review and keeps scope limited to compliance/documentation drift. @Vishnu2707 could you please review when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The scanner now contains 44 rules, but the rule reference and compliance framework JSON files had drifted. This could undercount compliance coverage and make the documentation disagree with the rule metadata shipped by the scanner.
Validation
python3 -m json.toolon all compliance framework JSON filespython3 -m pytest tests/test_rules_storage.py tests/test_rules_network.py tests/test_rules_identity.py tests/test_rules_database.py tests/test_rules_keyvault.py tests/test_pqc_rules.py -qpassed with22 passedNote: after installing the missing local Python packages, full
python3 -m pytest -qis still blocked locally becauseapi.appinitializes the Flask app and database migrations at import time, and this shell does not haveDATABASE_URLconfigured.