feat(edge-ocp-rc): add multi-release job collection#227
Conversation
Add collect.sh to fetch CI jobs for all topologies and releases from
Sippy in a single command. Restructure job files into release
subdirectories (jobs/{release}/) and update launch.sh and status.sh
to resolve paths accordingly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhensel-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThe plugin now collects Sippy jobs into release-scoped TNF/TNA files. Launch and status scripts discover, list, refresh, count, and locate jobs using ChangesRelease-scoped job management
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 markdownlint-cli2 (0.23.0)plugins/edge-ocp-rc/README.mdmarkdownlint-cli2 v0.23.0 (markdownlint v0.41.0) ... [truncated 1078 characters] ... node:internal/modules/esm/resolve:271:11) Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/edge-ocp-rc/README.md`:
- Line 184: Update the delay documentation in the README to match the default
DELAY value used by the launch.sh script, ensuring the stated interval
accurately reflects the script’s behavior and rate-limit guidance.
In `@plugins/edge-ocp-rc/scripts/collect.sh`:
- Around line 33-54: Update the job-file generation flow in collect.sh to write
parsed results to temporary files rather than deleting the existing job files
first. Only after jq and the downstream pipeline complete successfully should
the temporary files replace job_file, job_file_z, and job_file_y atomically;
preserve the existing files when parsing or collection fails, and clean up
temporary files on failure.
In `@plugins/edge-ocp-rc/scripts/launch.sh`:
- Around line 40-51: Update detect_release() so automatic detection does not
select the first matching release from jobs/*/. Require an explicit version when
multiple release directories are present, or fail clearly instead of returning
an arbitrary value; preserve current detection when exactly one release
directory exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d8f0f733-306d-4e28-b13f-8279cffa696b
📒 Files selected for processing (4)
plugins/edge-ocp-rc/README.mdplugins/edge-ocp-rc/scripts/collect.shplugins/edge-ocp-rc/scripts/launch.shplugins/edge-ocp-rc/scripts/status.sh
Write job files atomically via temp files to avoid data loss on Sippy failures, require explicit version when multiple release dirs exist, fix delay docs to match default, and make DELAY overridable via env. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
ready-for-human-review
1 participant
Summary
scripts/collect.shto fetch CI jobs for all topologies (TNF, TNA) across releases (4.22, 4.23, 5.0) from Sippy in a single commandjobs/{release}/) so multiple releases can coexistlaunch.shandstatus.shto resolve paths from the new directory structureTest plan
scripts/collect.shand verify job files are created underjobs/4.22/,jobs/5.0/etc.scripts/launch.sh tnf --list(no version) and verify all releases are shownscripts/launch.sh tna 4.22 --listand verify single-release listing worksscripts/launch.sh tnf 5.0.0 --refreshand verify it writes tojobs/5.0/scripts/launch.sh tnf 5.0.0-rc.0 --job all --dry-runand verify jobs resolve correctly🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
jobs/<release>/for TNF/TNA workflows.Documentation
jobs/<release>/paths and clarified the recommended collect vs. refresh workflow.DELAY=30 ....