Skip to content

Conversation

@cardil
Copy link
Member

@cardil cardil commented Jul 2, 2025

/kind cleanup

@cardil cardil requested a review from Copilot July 2, 2025 10:20
@openshift-ci openshift-ci bot added the kind/cleanup Clean up code label Jul 2, 2025
@openshift-ci openshift-ci bot requested review from creydr and maschmid July 2, 2025 10:20
@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Go toolchain and linting setup and refactors code to use new Operation-scoped fields rather than deep Config references.

  • Bump Go version to 1.24 in go.work, go.mod, build modules, and workflows; upgrade golangci-lint to v2.0.2
  • Refactor packages under pkg/sync and pkg/git to replace o.Config.* calls with direct Operation fields
  • Revise .golangci.yaml to enable default all linters and consolidate settings

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/sync/trigger_ci.go Use Operation fields for CI trigger instead of Config.*
pkg/sync/sync_release_next.go Replace push branch arg with Operation.ReleaseNext
pkg/sync/resync_releases.go Swap Config.ResyncReleases refs for direct Operation fields
pkg/sync/reset_release_next.go Use direct fields in reset logic instead of Config.*
pkg/sync/remove_unwanted_upstream_files.go Call delete via Operation.Path instead of Config project path
pkg/sync/operation.go Rewrite repository calls to use Operation methods/fields
pkg/sync/mirror_release.go Switch remote URLs and template refs to Operation fields
pkg/sync/mirror_branches.go Update regex and remote list calls to use Operation fields
pkg/sync/generate_images.go Reference DockerfileGen from Operation
pkg/sync/fork_files.go Change upstream URL and copy path to Operation fields
pkg/sync/create_pr.go Utilize Operation message fields and path in PR creation
pkg/sync/apply_patches.go Use Operation.Path for patches directory and workspace context
pkg/log/labeled.go Simplify loop with for i := range v
pkg/github/client.go Convert Execute to named returns and use errors.Join
pkg/git/remote.go Call CreateRemote via method shorthand on Repository
pkg/git/merge.go Change working directory reference to r.Path
pkg/git/fetch.go Update fetch invocation to use shortcut r.FetchContext
pkg/git/commit.go Replace r.Repository.Worktree() with r.Worktree()
pkg/git/checkout_test.go Switch to t.Context() in tests
pkg/git/checkout.go Use o.repo.Path in clone URL rather than Project.Path
pkg/git/auth.go Add //nolint:nilnil for HTTP auth return
pkg/errors/wrap.go Update nolint tag and add Join wrapper
pkg/config/defaults.go Remove unused gomnd tag and bump default resync count
go.work Bump Go version to 1.24.0
go.mod Bump Go version to 1.24.0
build/go.mod Bump Go version to 1.24.0
build/Magefile.go Upgrade golangci-lint check to v2.0.2
.golangci.yaml Switch to default: all, reorganize linter settings
.github/workflows/mage.yaml Update Go matrix to include 1.24
.github/workflows/lint.yaml Bump setup-go and golangci-lint action versions

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cardil
Copy link
Member Author

cardil commented Jul 2, 2025

Merging as this is just a dep bump

@cardil cardil added the lgtm label Jul 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 26cee86 into openshift-knative:main Jul 2, 2025
4 checks passed
@cardil cardil deleted the chore/bump-golang branch July 2, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant