-
Notifications
You must be signed in to change notification settings - Fork 2
✴️ Bump golang & lint #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✴️ Bump golang & lint #52
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Go toolchain and linting setup and refactors code to use new Operation-scoped fields rather than deep Config references.
- Bump Go version to 1.24 in
go.work,go.mod, build modules, and workflows; upgrade golangci-lint to v2.0.2 - Refactor packages under
pkg/syncandpkg/gitto replaceo.Config.*calls with directOperationfields - Revise
.golangci.yamlto enable default all linters and consolidate settings
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sync/trigger_ci.go | Use Operation fields for CI trigger instead of Config.* |
| pkg/sync/sync_release_next.go | Replace push branch arg with Operation.ReleaseNext |
| pkg/sync/resync_releases.go | Swap Config.ResyncReleases refs for direct Operation fields |
| pkg/sync/reset_release_next.go | Use direct fields in reset logic instead of Config.* |
| pkg/sync/remove_unwanted_upstream_files.go | Call delete via Operation.Path instead of Config project path |
| pkg/sync/operation.go | Rewrite repository calls to use Operation methods/fields |
| pkg/sync/mirror_release.go | Switch remote URLs and template refs to Operation fields |
| pkg/sync/mirror_branches.go | Update regex and remote list calls to use Operation fields |
| pkg/sync/generate_images.go | Reference DockerfileGen from Operation |
| pkg/sync/fork_files.go | Change upstream URL and copy path to Operation fields |
| pkg/sync/create_pr.go | Utilize Operation message fields and path in PR creation |
| pkg/sync/apply_patches.go | Use Operation.Path for patches directory and workspace context |
| pkg/log/labeled.go | Simplify loop with for i := range v |
| pkg/github/client.go | Convert Execute to named returns and use errors.Join |
| pkg/git/remote.go | Call CreateRemote via method shorthand on Repository |
| pkg/git/merge.go | Change working directory reference to r.Path |
| pkg/git/fetch.go | Update fetch invocation to use shortcut r.FetchContext |
| pkg/git/commit.go | Replace r.Repository.Worktree() with r.Worktree() |
| pkg/git/checkout_test.go | Switch to t.Context() in tests |
| pkg/git/checkout.go | Use o.repo.Path in clone URL rather than Project.Path |
| pkg/git/auth.go | Add //nolint:nilnil for HTTP auth return |
| pkg/errors/wrap.go | Update nolint tag and add Join wrapper |
| pkg/config/defaults.go | Remove unused gomnd tag and bump default resync count |
| go.work | Bump Go version to 1.24.0 |
| go.mod | Bump Go version to 1.24.0 |
| build/go.mod | Bump Go version to 1.24.0 |
| build/Magefile.go | Upgrade golangci-lint check to v2.0.2 |
| .golangci.yaml | Switch to default: all, reorganize linter settings |
| .github/workflows/mage.yaml | Update Go matrix to include 1.24 |
| .github/workflows/lint.yaml | Bump setup-go and golangci-lint action versions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Merging as this is just a dep bump |
26cee86
into
openshift-knative:main
/kind cleanup