🐛 Don't delete branch twice

[cardil]

/kind bug

Closes #42

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cardil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[Copilot]

Pull Request Overview

This PR adds an option to skip deleting a branch when pushing, and updates related calls, CLI argument handling, and logging output.

• Introduces a pushOpt type and skipDeleteOnPush in pushBranch.
• Propagates the new option through resync_releases and mirror_release.
• Updates CLI for sync command to accept an optional project directory and silences usage messages; fixes buffer logging to use string(buff).

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/sync/sync_release_next.go	Added pushOpt, skipDeleteOnPush, and updated pushBranch signature
pkg/sync/resync_releases.go	Passed skipDeleteOnPush into pushBranch
pkg/sync/mirror_release.go	Added skipDelete flag and conditional delete step
pkg/sync/create_pr.go	Changed buffer print to string(buff)
internal/cmd/sync.go	Made project-dir an optional argument and updated Use/Args
internal/cmd/root.go	Set SilenceUsage = true in a persistent pre-run hook

Comments suppressed due to low confidence (2)

internal/cmd/sync.go:20

• The ValidArgs list still refers to REPOSITORY but the command now accepts an optional project-dir. Consider updating or removing ValidArgs to reflect the new usage.

		ValidArgs: []string{"REPOSITORY"},

pkg/sync/mirror_release.go:83

• There isn’t currently a test verifying that skipDeleteOnPush prevents the delete step. Consider adding a unit test for this new behavior.

	if !p.skipDelete {