Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2025

Bumps github.com/cli/cli/v2 from 2.65.0 to 2.67.0.

Release notes

Sourced from github.com/cli/cli/v2's releases.

GitHub CLI 2.67.0

Security

A bug in gh attestation verify may return an incorrect zero exit status when no matching attestations are found for the specified --predicate-type <value> or the default https://slsa.dev/provenance/v1 if not specified. This issue only arises if an artifact has an attestation with a predicate type different from the one provided in the command. As a result, users relying solely on these exit codes may mistakenly believe the attestation has been verified, despite the absence of an attestation with the specified predicate type and the tool printing a verification failure.

Users are advised to update gh to version v2.67.0 as soon as possible.

For more information, see GHSA-fgw4-v983-mgp8

gh pr checkout now supports interactively selecting a pull request

Similar to commands like gh workflow run which prompts for a workflow to run, now gh pr checkout will prompt for a pull request to checkout. The list is currently limited to the most recent 10 pull requests in the repository.

393797385-499b5dfb-3103-42b8-876a-3a2d4d7173c8.mov

Big thank you to @​nilvng for implementing this 🙌

Contributing guidelines updated

We've updated our CONTRIBUTING.md guidelines to give more clarity around old help wanted issues.

TLDR:

  • Please directly mention @cli/code-reviewers when an issue you want to work on does not have clear Acceptance Criteria
  • Please only open pull requests for issues with both the help wanted label and clear Acceptance Criteria
  • Please avoid expanding pull request scope to include changes that are not described in the connected issue's Acceptance Criteria

Note: Acceptance Criteria is posted as an issue comment by a core maintainer.

See cli/cli#10381 and cli/cli#10395 for more information.

❓ Have feedback on anything? We'd love to hear from you in a discussion post ❤️

What's Changed

✨ Features

🐛 Fixes

... (truncated)

Commits
  • 6899fe2 Merge pull request #10421 from cli/exit1-wrong-predicate-type
  • bf3a40a Exit with error if no matching predicate type exists
  • 5557958 Merge pull request #10362 from hoffm/delete-autolinks
  • ab7fdaa Merge pull request #10395 from cli/kw/code-review-suggestions-for-contributin...
  • 0268d95 Fix logic error in contributing docs
  • 8e2be73 Improve http error test cases
  • 9eaaf44 Handle non-TTY behavior
  • 8d0ec0a Merge branch 'trunk' into delete-autolinks
  • 0a05012 Merge pull request #10379 from cli/dependabot/go_modules/google.golang.org/pr...
  • c1bc836 Merge pull request #10388 from jsoref/issue-9927
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 24, 2025
@openshift-ci openshift-ci bot requested review from cardil and creydr February 24, 2025 16:48
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign maschmid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil
Copy link
Member

cardil commented Feb 24, 2025

/hold only after upgrade to 1.23

module github.com/openshift-knative/deviate

go 1.22.9
toolchain go1.23.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't bump it until we switch to go 1.23 for the product

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cli/cli/v2-2.67.0 branch from 39f6a9f to 4e37a2f Compare February 27, 2025 20:04
@cardil cardil force-pushed the main branch 2 times, most recently from a0f315c to 4d07a14 Compare February 27, 2025 20:13
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cli/cli/v2-2.67.0 branch from 4e37a2f to 7e163d2 Compare February 27, 2025 20:21
Bumps [github.com/cli/cli/v2](https://github.com/cli/cli) from 2.65.0 to 2.67.0.
- [Release notes](https://github.com/cli/cli/releases)
- [Changelog](https://github.com/cli/cli/blob/trunk/.goreleaser.yml)
- [Commits](cli/cli@v2.65.0...v2.67.0)

---
updated-dependencies:
- dependency-name: github.com/cli/cli/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cli/cli/v2-2.67.0 branch from 7e163d2 to 2a5777e Compare March 3, 2025 19:00
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 6, 2025

Superseded by #26.

@dependabot dependabot bot closed this Mar 6, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/cli/cli/v2-2.67.0 branch March 6, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do-not-merge/hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants