NO-JIRA: Fix hardcoded x86_64 references in agent and boot-image paths#1910
NO-JIRA: Fix hardcoded x86_64 references in agent and boot-image paths#1910fonta-rh wants to merge 2 commits into
Conversation
Replace hardcoded x86_64 architecture strings with $(uname -m) or
${ARCH} so that agent-based installation scripts work on aarch64
hosts (e.g. AWS Graviton bare metal).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @fonta-rh. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
On aarch64 (virt machine type), virt-xml defaults the CDROM bus to USB when no bus is specified. The virt machine type has no USB controller, causing "USB is disabled for this domain" errors when attaching the agent ISO at step 06. Set target.bus explicitly on all five virt-xml CDROM attachment calls: sata on x86_64 (q35 default), scsi on aarch64 (matching the bus already configured by 02_configure_host.sh). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fonta-rh
force-pushed
the
aarch64-agent-path-fixes
branch
from
62668e0 to
791e826
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
Consolidated into #1908, which now carries all three aarch64 fixes (CPU model, hardcoded x86_64 refs, CDROM bus). Validated end-to-end on Graviton c7g.metal. |
1 participant
Summary
x86_64architecture strings with$(uname -m)or${ARCH}in agent-based installation scripts and RHCOS boot image resolutionChanges
agent/common.shagent/iscsi_utils.shagent/07_agent_add_extraworker_nodes.shagent/iso_no_registry.shagent/01_agent_requirements.shrhcos.sh.architectures.x86_64, now uses host arch)Context
Companion to #1908 (CPU model fix for native aarch64 KVM). That PR fixes the IPI VM template; this one fixes the agent-based installation path. Both are independent and can merge in either order.
Test plan
x86_64on x86 hosts)🤖 Generated with Claude Code