Fix agentic SDLC check: resolve @ includes, switch to informing mode - #790
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm |
Two fixes for the agentic SDLC conformance check pipeline: 1. Resolve CLAUDE.md @ includes: repos using `@AGENTS.md` (or similar include directives) had content checks fail because the script only read CLAUDE.md itself. Now resolves one level of @ references and checks the combined content. Deduplicates with sort -u. 2. Add onError: continue to both check tasks so the pipeline always passes at the PipelineRun level. Non-conformance is still visible in the individual task status (red task in Konflux UI) but the overall check reports success. This avoids noisy red X signals on repos that are still being onboarded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
c7e8a5d to
1000b99
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexSmithGH, clcollins, tnierman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Two fixes for the agentic SDLC conformance check pipeline added in #788:
Resolve CLAUDE.md
@includes — repos using@AGENTS.md(or similar Claude Code include directives) had content checks fail because the script only read CLAUDE.md itself. Now resolves one level of@references, deduplicates withsort -u, and checks the combined content.Add
onError: continueto both check tasks so the pipeline always passes at the PipelineRun level. Non-conformance is still visible in the individual task status (red task in Konflux UI) but the overall GitHub check reports success.What changed
check-file-existencetaskonError: continuecheck-content-validationtaskonError: continue@references one level deep before checking for required sectionsTesting
Validated locally against
openshift/deadmanssnitch-operator(which uses@AGENTS.mdas its CLAUDE.md):@AGENTS.mdtext)CLAUDE.md + AGENTS.md, finds all required sections, passes 17/18 (1 advisory warning)🤖 Generated with Claude Code