Update UBI 9 base image to 9.8-1785906690 - #834
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Dockerfile updates the UBI9 base image tag in both builder and runtime stages. Other Docker build and runtime instructions remain unchanged. ChangesUBI9 image refresh
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
config/Dockerfile (1)
31-31: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winSecurity Misconfiguration (CWE-16)
Reachability: Internal · Exploitability: Theoretical
Document the approved CI build-image exception.
config/Dockerfileproduces a published CI build image, so its Go tools are intentional. Document the approved exception. If this image is used at runtime, move the CI toolchain to a separate image.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/Dockerfile` at line 31, Document the approved exception alongside the config/Dockerfile base image, explaining that the published CI build image intentionally includes Go tooling. If this Dockerfile is also used for runtime workloads, separate the CI toolchain into a dedicated image instead.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/Dockerfile`:
- Line 31: Add a suitable HEALTHCHECK instruction to the Dockerfile based on the
one-shot CI command usage, or document the approved exception directly if health
checks are intentionally inappropriate. Keep the existing base image and
container behavior unchanged.
- Around line 4-6: Update the final-stage GOCILINT_VERSION declaration to
v2.12.2 so it matches the builder-stage version used by GOCILINT_LOCATION; leave
the checksum and download URL configuration unchanged.
- Line 2: Update both UBI9 base-image declarations in config/Dockerfile at lines
2-2 and 31-31, replacing the pinned 9.8-1785906690 tag with the approved
floating UBI9 tag so both builder and runtime stages receive managed updates.
---
Nitpick comments:
In `@config/Dockerfile`:
- Line 31: Document the approved exception alongside the config/Dockerfile base
image, explaining that the published CI build image intentionally includes Go
tooling. If this Dockerfile is also used for runtime workloads, separate the CI
toolchain into a dedicated image instead.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b0a4e6a4-03bf-4d64-ab2d-f7bbc992a7f9
⛔ Files ignored due to path filters (2)
boilerplate/openshift/golang-lint/ensure.shis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/ensure.shis excluded by!boilerplate/**
📒 Files selected for processing (1)
config/Dockerfile
Bump both builder and runtime stages from ubi9:9.7-1778044007 / ubi9:9.8-1781496985 to ubi9:9.8-1785906690. This picks up go-toolset 1.26.5-1.el9_8 (from 1.26.3) and latest RPM security fixes. Created with assistance from Claude 🤖 <claude@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
1e7c65c to
d97f0e1
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, joshbranham The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
ubi9:9.7-1778044007toubi9:9.8-1785906690ubi9:9.8-1781496985toubi9:9.8-1785906690go-toolset 1.26.5-1.el9_8(from 1.26.3), enabling downstream operators to build with Go 1.26.5Test plan
go versionin built image reports1.26.5🤖 Created with assistance from Claude claude@anthropic.com
Summary by CodeRabbit