Skip to content

[cert-manager-1.15] CM-423: Adds e2e test for istio-csr controller with grpc CreateCertificate call #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 4 commits into from
Mar 6, 2025
Merged

[cert-manager-1.15] CM-423: Adds e2e test for istio-csr controller with grpc CreateCertificate call #250

openshift-merge-bot merged 4 commits into from
Mar 6, 2025

Conversation

@PillaiManish
Copy link
Member

@PillaiManish PillaiManish commented Mar 4, 2025 •
edited
Loading

Manual cherry-pick of #212, #226, #247, #248 into cert-manager-1.15 branch.

@openshift-ci openshift-ci bot requested review from TrilokGeer and swghosh March 4, 2025 11:38
@swghosh
Copy link
Member

swghosh commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

/retitle [cert-manager-1.15] CM-423: Adds e2e test for istio-csr controller with grpc CreateCertificate call

@openshift-ci openshift-ci bot changed the title [cert-manager-1.15] Cherry Pick from master [cert-manager-1.15] CM-423: Adds e2e test for istio-csr controller with grpc CreateCertificate call Mar 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Details

In response to this:

Manual cherry-pick of #226, #247, #248 into cert-manager-1.15 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member

swghosh commented Mar 4, 2025

/label docs-approved
/label px-approved
This is a cherry-pick.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 4, 2025
@swghosh
Copy link
Member

swghosh commented Mar 4, 2025 •
edited
Loading

@PillaiManish seems the test/e2e/* files did not yet fully resolve the code conflicts from the cherry-pick(s),
causing build failures in the e2e run. Those would need to be fixed.

@PillaiManish PillaiManish force-pushed the cherry-pick-cert-manager-1.15 branch from 79ff836 to 7b1f9f0 Compare March 5, 2025 10:20
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Details

In response to this:

Manual cherry-pick of #212, #226, #247, #248 into cert-manager-1.15 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member

swghosh commented Mar 5, 2025

/lgtm

/cc @lunarwhite
for qe-approved label

/assign @TrilokGeer
for final approval

@openshift-ci openshift-ci bot requested a review from lunarwhite March 5, 2025 11:40
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@swghosh swghosh removed their assignment Mar 5, 2025
@swghosh
Copy link
Member

swghosh commented Mar 5, 2025

/hold
e2e is running a GCP test case which it should really skip.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2025
@lunarwhite
Copy link
Member

lunarwhite commented Mar 5, 2025

@swghosh Sorry, we should also land this cherrypick at earlier time: #251 (Ginkgo label filter) 😅

@swghosh
Copy link
Member

swghosh commented Mar 5, 2025 •
edited
Loading

/hold
e2e is running a GCP test case which it should really skip.

Thanks @lunarwhite for fixing the regression,
we'll land this only after #251 is in.

@swghosh swghosh mentioned this pull request Mar 5, 2025
Merged
@swghosh
Copy link
Member

swghosh commented Mar 6, 2025

/remove-hold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025
lunarwhite and others added 3 commits March 6, 2025 14:17
@lunarwhite @PillaiManish
add a helper func to dump namespaced events
49cce7a 
* create DumpEventsInNamespace
* tweak CreateTestingNS and DeleteTestingNS logic, move them to BeforeEach()
* change the global wait-poll interval to a less aggressive value
@swghosh @PillaiManish
refactor: Use go text/template in e2e testdata
f50eb63 
for extensible replacement of field values

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@PillaiManish
adds e2e test case for istio-csr:#423
f951da6 
  - applys IstioCSR resource
  - deploys grpcurl job - which calls the grpc endpoint of istio-csr
  - checks the response and validates the certificate
@PillaiManish PillaiManish force-pushed the cherry-pick-cert-manager-1.15 branch from 7b1f9f0 to c64c3ac Compare March 6, 2025 08:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025
@lunarwhite
Copy link
Member

lunarwhite commented Mar 6, 2025 •
edited
Loading

Case Cert Manager Suite: [It] Istio-CSR grpc call istio.v1.auth.IstioCertificateService/CreateCertificate to istio-csr agent should return cert-chain as response [TechPreview, Feature:IstioCSR] passed in e2e-operator-tech-preview, skipped in e2e-operator as we expected.

The failure/flakiness is being tracked by https://issues.redhat.com/browse/CM-485, and I'm planning to mitigate it in a separate PR.

--- FAIL: TestCertRenew (12.34s)
--- FAIL: TestCertRenew (12.40s)

In the meantime, let's try it again to unblock this PR from being merged:
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

@PillaiManish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-tech-preview c64c3ac link false /test e2e-operator-tech-preview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lunarwhite
Copy link
Member

lunarwhite commented Mar 6, 2025

Rerun e2e-operator is passing

Ran 25 of 29 Specs in 766.635 seconds
SUCCESS! -- 25 Passed | 0 Failed | 0 Pending | 4 Skipped
--- PASS: TestAll (766.64s)
PASS
ok  	github.com/openshift/cert-manager-operator/test/e2e	933.034s

@lunarwhite
Copy link
Member

lunarwhite commented Mar 6, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2025 •
edited by openshift-ci bot
Loading

@PillaiManish: This pull request references CM-423 which is a valid jira issue.

Details

In response to this:

Manual cherry-pick of #212, #226, #247, #248 into cert-manager-1.15 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TrilokGeer
Copy link
Contributor

TrilokGeer commented Mar 6, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PillaiManish, swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c8120b6 into openshift:cert-manager-1.15 Mar 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swghosh swghosh Awaiting requested review from swghosh

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

@lunarwhite lunarwhite Awaiting requested review from lunarwhite

Assignees

@TrilokGeer TrilokGeer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PillaiManish @swghosh @openshift-ci-robot @lunarwhite @TrilokGeer @openshift-merge-robot